[PATCH] D50374: [SelectionDAG] When splitting scatter nodes during DAGCombine, create a serial chain dependency.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 00:19:42 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:7426
-
-  AddToWorklist(Lo.getNode());
-  AddToWorklist(Hi.getNode());
----------------
I removed the AddToWorklist calls because the worklist code in the DAGCombiner ensure all operands of visited nodes have been added to worklist. So we return Hi, which should get added to the worklist and then visited. Lo is an operand of Hi due to the chain so it should get added to the worklist then.


Repository:
  rL LLVM

https://reviews.llvm.org/D50374





More information about the llvm-commits mailing list