[PATCH] D50288: [ARM64] [Windows] Exception handling, part #2

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 23:51:24 PDT 2018


hans added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:1889
+  // emitPrologue if it gets called and emits CFI.
+  MF.setHasWinCFI(false);
+
----------------
rnk wrote:
> Hm, looks like I added this for X86. It seems more confusing than just defaulting MachineFunction::HasWinCFI to false. @hans, would you be OK if I made that Optional<bool> into a plain bool initialized to false? It seems intuitive enough that if emitPrologue isn't called (for naked functions), the function doesn't have CFI.
Sounds good to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D50288





More information about the llvm-commits mailing list