[PATCH] D50238: [ARM] FP16: support the vector vmin and vmax variants
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 6 17:53:23 PDT 2018
efriedma added a comment.
SelectionDAGBuilder::visitSelect can also generate FMINNAN etc.; please add testcases.
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:1140
setOperationAction(ISD::FMINNAN, MVT::f16, Legal);
setOperationAction(ISD::FMAXNAN, MVT::f16, Legal);
setOperationAction(ISD::FMINNAN, MVT::f32, Legal);
----------------
Maybe not actually a part of this patch, but how does this work without hasFullFP16()?
https://reviews.llvm.org/D50238
More information about the llvm-commits
mailing list