[PATCH] D49727: [CodeGen] emit inline asm clobber list warnings for reserved

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:556
+    auto Msg = std::string("inline asm clobber list contains reserved "
+                           "registers: ");
+    for (auto I = RestrRegs.begin(), E = RestrRegs.end(); I != E; I++) {
----------------
Standard style is `std::string Msg = "...";`.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:566
+    SrcMgr.PrintMessage(Loc, SourceMgr::DK_Warning, Msg);
+    SrcMgr.PrintMessage(SMLoc(), SourceMgr::DK_Note, Note);
+  }
----------------
Doesn't the note need the same location to print correctly?


https://reviews.llvm.org/D49727