[PATCH] D49512: [CodeGenPrepare] Add BothExtension type to PromotedInsts

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 17:17:38 PDT 2018


qcolombet added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:3600
-  PromotedInsts.insert(std::pair<Instruction *, TypeIsSExt>(
-      ExtOpnd, TypeIsSExt(ExtOpnd->getType(), IsSExt)));
   // Step #1.
----------------
Instead of insert, we should do update the value all the time.


https://reviews.llvm.org/D49512





More information about the llvm-commits mailing list