[PATCH] D50292: [WebAssembly] Update SIMD binary arithmetic

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 16:55:41 PDT 2018


tlively added a comment.

Landed https://reviews.llvm.org/rL339082 to address comments.



================
Comment at: lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp:261
+  case MVT::v4f32:
+  case MVT::v2f64: retType = WebAssembly::ExprType::V128; break;
   case MVT::ExceptRef: retType = WebAssembly::ExprType::ExceptRef; break;
----------------
aheejin wrote:
> Can you clang-format this?
Done in https://reviews.llvm.org/D50367.


================
Comment at: test/CodeGen/WebAssembly/simd-arith.ll:150
+; SIMD128: return $pop0{{$}}
+define <2 x i64> @mul_v2i64(<2 x i64> %x, <2 x i64> %y) {
+  %a = mul <2 x i64> %x, %y
----------------
dschuff wrote:
> missing div?
SIMD integer div ops are not in the spec


Repository:
  rL LLVM

https://reviews.llvm.org/D50292





More information about the llvm-commits mailing list