[PATCH] D49913: Make TargetInstrInfo::isCopyInstr return true for regular COPY-instructions

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.
Nitpicks on the comments.



================
Comment at: include/llvm/CodeGen/TargetInstrInfo.h:866
+  /// instructions the method calls target-dependent implementation.
+  bool isCopyInstr(const MachineInstr &MI, const MachineOperand *&SourceOpNum,
+                   const MachineOperand *&Destination) const {
----------------
The naming between the doxygen comment and the variable does not match (Source vs SourceOpNum).


================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.h:107
+  /// @Source machine operand and @Destination machine operand.
+  bool isCopyInstrImpl(const MachineInstr &MI, const MachineOperand *&Src,
+                       const MachineOperand *&Dest) const override;
----------------
Ditto.


https://reviews.llvm.org/D49913