[PATCH] D50370: [SampleFDO] Fix a bug in getOrCompHotCountThreshold/getOrCompColdCountThreshold

[Wei Mi via Phabricator via llvm-commits]

wmi created this revision.
wmi added reviewers: danielcdh, davidxl.
Herald added a subscriber: eraman.

getOrCompHotCountThreshold/getOrCompColdCountThreshold introduced in https://reviews.llvm.org/D45377 contain a bad mistake and will only return 1 or 0 instead of the true hot/cold cutoff value. The patch fixes the mistake. But the mistake seems not causing big performance difference according to internal server benchmarks testing.


Repository:
  rL LLVM

https://reviews.llvm.org/D50370

Files:
  lib/Analysis/ProfileSummaryInfo.cpp
  test/Transforms/SampleProfile/Inputs/function_metadata.prof
  test/Transforms/SampleProfile/function_metadata.ll


Index: test/Transforms/SampleProfile/function_metadata.ll
===================================================================
--- test/Transforms/SampleProfile/function_metadata.ll
+++ test/Transforms/SampleProfile/function_metadata.ll
@@ -27,8 +27,10 @@
 }
 
 ; GUIDs of foo, bar, foo1, foo2 and foo3 should be included in the metadata to
-; make sure hot inline stacks are imported.
-; CHECK: ![[ENTRY_TEST]] = !{!"function_entry_count", i64 1, i64 2494702099028631698, i64 6699318081062747564, i64 7546896869197086323, i64 7682762345278052905,  i64 -7908226060800700466, i64 -2012135647395072713}
+; make sure hot inline stacks are imported. The total count of baz is lower
+; than the hot cutoff threshold and its GUID should not be included in the
+; metadata.
+; CHECK: ![[ENTRY_TEST]] = !{!"function_entry_count", i64 1, i64 2494702099028631698, i64 6699318081062747564, i64 7682762345278052905,  i64 -7908226060800700466, i64 -2012135647395072713}
 
 ; Check GUIDs for both foo and foo_available are included in the metadata to
 ; make sure the liveness analysis can capture the dependency from test_liveness
Index: test/Transforms/SampleProfile/Inputs/function_metadata.prof
===================================================================
--- test/Transforms/SampleProfile/Inputs/function_metadata.prof
+++ test/Transforms/SampleProfile/Inputs/function_metadata.prof
@@ -1,4 +1,6 @@
 test:10000:0
+ 2: 100
+ 3: 100
  3: foo:1000
   3: bar:200
    4: baz:10
Index: lib/Analysis/ProfileSummaryInfo.cpp
===================================================================
--- lib/Analysis/ProfileSummaryInfo.cpp
+++ lib/Analysis/ProfileSummaryInfo.cpp
@@ -226,13 +226,13 @@
 uint64_t ProfileSummaryInfo::getOrCompHotCountThreshold() {
   if (!HotCountThreshold)
     computeThresholds();
-  return HotCountThreshold && HotCountThreshold.getValue();
+  return HotCountThreshold ? HotCountThreshold.getValue() : UINT64_MAX;
 }
 
 uint64_t ProfileSummaryInfo::getOrCompColdCountThreshold() {
   if (!ColdCountThreshold)
     computeThresholds();
-  return ColdCountThreshold && ColdCountThreshold.getValue();
+  return ColdCountThreshold ? ColdCountThreshold.getValue() : 0;
 }
 
 bool ProfileSummaryInfo::isHotBB(const BasicBlock *B, BlockFrequencyInfo *BFI) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50370.159431.patch
Type: text/x-patch
Size: 2268 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180806/51cc4304/attachment.bin>