[lld] r339075 - [lit, python] Always add quotes around the python path in lit

Stella Stamenova via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 15:37:49 PDT 2018


Author: stella.stamenova
Date: Mon Aug  6 15:37:49 2018
New Revision: 339075

URL: http://llvm.org/viewvc/llvm-project?rev=339075&view=rev
Log:
[lit, python] Always add quotes around the python path in lit

Summary:
The issue with the python path is that the path to python on Windows can contain spaces. To make the tests always work, the path to python needs to be surrounded by quotes.

This is a companion change to: https://reviews.llvm.org/D50206

Reviewers: asmith, zturner, espindola

Subscribers: emaste, sbc100, arichardson, aheejin, steven_wu, dexonsmith, llvm-commits

Differential Revision: https://reviews.llvm.org/D50282

Modified:
    lld/trunk/test/ELF/lto/cache.ll
    lld/trunk/test/mach-o/dependency_info.yaml
    lld/trunk/test/wasm/lto/cache.ll

Modified: lld/trunk/test/ELF/lto/cache.ll
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/cache.ll?rev=339075&r1=339074&r2=339075&view=diff
==============================================================================
--- lld/trunk/test/ELF/lto/cache.ll (original)
+++ lld/trunk/test/ELF/lto/cache.ll Mon Aug  6 15:37:49 2018
@@ -13,7 +13,7 @@
 ; RUN: ls %t.cache | count 4
 
 ; Create a file of size 64KB.
-; RUN: "%python" -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
+; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
 
 ; This should leave the file in place.
 ; RUN: ld.lld --thinlto-cache-dir=%t.cache --thinlto-cache-policy cache_size_bytes=128k:prune_interval=0s -o %t3 %t2.o %t.o

Modified: lld/trunk/test/mach-o/dependency_info.yaml
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/mach-o/dependency_info.yaml?rev=339075&r1=339074&r2=339075&view=diff
==============================================================================
--- lld/trunk/test/mach-o/dependency_info.yaml (original)
+++ lld/trunk/test/mach-o/dependency_info.yaml Mon Aug  6 15:37:49 2018
@@ -9,7 +9,7 @@
 # RUN:        -F/Custom/Frameworks \
 # RUN:        -framework Bar \
 # RUN:        -framework Foo
-# RUN: '%python' %p/Inputs/DependencyDump.py %t.info | FileCheck %s
+# RUN: %python %p/Inputs/DependencyDump.py %t.info | FileCheck %s
 
 
 # CHECK: linker-vers: lld

Modified: lld/trunk/test/wasm/lto/cache.ll
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/wasm/lto/cache.ll?rev=339075&r1=339074&r2=339075&view=diff
==============================================================================
--- lld/trunk/test/wasm/lto/cache.ll (original)
+++ lld/trunk/test/wasm/lto/cache.ll Mon Aug  6 15:37:49 2018
@@ -11,7 +11,7 @@
 ; RUN: ls %t.cache | count 4
 
 ; Create a file of size 64KB.
-; RUN: "%python" -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
+; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
 
 ; This should leave the file in place.
 ; RUN: wasm-ld --thinlto-cache-dir=%t.cache --thinlto-cache-policy cache_size_bytes=128k:prune_interval=0s -o %t.wasm %t2.o %t.o




More information about the llvm-commits mailing list