[PATCH] D44748: Track whether the size of a MemoryLocation is precise

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

This change is *still* too large to comfortably review in one pass.  I *strongly encourage* you to take a look through this and take every opportunity to split off small NFC refactorings to reduce the diff length and complexity.  I've highlighted a couple options for you, but there are likely others.



================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:1115
   if (!Pair.second) {
-    if (CacheInfo->Size < Loc.Size) {
-      // The query's Size is greater than the cached one. Throw out the
----------------
This does not look NFC.


================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:352
 
+  uint64_t LaterSize = Later.Size.getValue();
+  uint64_t EarlierSize = Earlier.Size.getValue();
----------------
If I'm reading this write, you can extract the majority of the mechanical updates to this function by adding the two variables to the old style code.  Please do so shrink the diff.  Also, make const.


https://reviews.llvm.org/D44748