[PATCH] D48153: Add TARGET(foo) linker script directive.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/ScriptParser.cpp:486
+
+  if (Tok.startswith("elf"))
+    Config->FormatBinary = false;
----------------
ruiu wrote:
> rdhindsa wrote:
> > Should "default" case be handled here as well?
> I don't think so. We add features as-needed basis, so we don't add a lot of features ahead of time.
You have separate commit to change `Driver.cpp:isOutputFormatBinary`. If we want to proceed with adding the `TARGET()` linker command, these lines should be better off unified with that function.


https://reviews.llvm.org/D48153