[PATCH] D50219: [ADT] Normalize empty triple components

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 13:13:21 PDT 2018


echristo accepted this revision.
echristo added inline comments.


================
Comment at: llvm/unittests/ADT/TripleTest.cpp:1178
 TEST(TripleTest, NormalizeARM) {
-  EXPECT_EQ("armv6--netbsd-eabi", Triple::normalize("armv6-netbsd-eabi"));
-  EXPECT_EQ("armv7--netbsd-eabi", Triple::normalize("armv7-netbsd-eabi"));
----------------
phosek wrote:
> echristo wrote:
> > What should we do here instead?
> I'm not sure I understand the question? `armv6-netbsd-eabi` got normalized to `armv6-unknown-netbsd-eabi`, isn't that expected?
Oh, I was reading it backwards. Nevermind.


Repository:
  rL LLVM

https://reviews.llvm.org/D50219





More information about the llvm-commits mailing list