[PATCH] D50219: [ADT] Normalize empty triple components

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 13:07:52 PDT 2018


echristo added a comment.

LGTM. One inline comment.

-eric



================
Comment at: llvm/unittests/ADT/TripleTest.cpp:1178
 TEST(TripleTest, NormalizeARM) {
-  EXPECT_EQ("armv6--netbsd-eabi", Triple::normalize("armv6-netbsd-eabi"));
-  EXPECT_EQ("armv7--netbsd-eabi", Triple::normalize("armv7-netbsd-eabi"));
----------------
What should we do here instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D50219





More information about the llvm-commits mailing list