[PATCH] D48046: [test-suite] Backprop kernel from Rodinia Benchmark

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.

LGTM



================
Comment at: MultiSource/Benchmarks/Rodinia/backprop/backpropKernel.c:16-18
+    int in, int hid, int out, float input_units[in + 1],
+    float hidden_units[hid + 1], float output_units[out + 1],
+    float hidden_delta[hid + 1], float output_delta[out + 1],
----------------
You could add `static const restrict` to those as well.


================
Comment at: MultiSource/Benchmarks/Rodinia/backprop/backpropKernel.c:65
+                  (MOMENTUM * (hidden_prev_weights)[k][j]));
+        (hidden_weights)[k][j] += new_dw;
+        (hidden_prev_weights)[k][j] = new_dw;
----------------
[Nit] parenthesis not necessary around array name


https://reviews.llvm.org/D48046