[PATCH] D50166: [ARM64] [Windows] MCLayer support for exception handling

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 11:38:38 PDT 2018


rnk added a comment.

I think it was a mistake to put the Windows x64 .seh_ directives directly in MCStreamer. They should've been implemented similar to the way ARM CFI directives are implemented inside the `ARMTargetStreamer` class and the way CodeView FPO data is implemented entirely inside lib/Target/X86. Otherwise, we will continue to have a massive proliferation of every target's unwind info directives implemented in our main cross-platform assembler class, MCStreamer.

Does that make sense? You should be able to modify AArch64MCInstrLower.cpp to direct these AArch64-specific pseudo instructions over to the AArch64TargetStreamer class. The .cv_fpo_* directive implementations are probably your best guide.


Repository:
  rL LLVM

https://reviews.llvm.org/D50166





More information about the llvm-commits mailing list