[PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

In https://reviews.llvm.org/D48661#1189537, @bricci wrote:

> Just a nit but could you please add new-lines to your commit messages.


My bad, will remember this for future commits.

> Also the 3 bools in FixedPointSemantics are a little bit wasteful.
>  I don't know here if it matter but I have been spending the last weeks
>  cleaning up this kind of thing and this already cut the time of an fsyntax-only
>  by ~3.5%.

Would you recommend something along the lines of having a bitmask instead of 3 bools? What should I keep in mind to avoid making fsyntax-only longer?

> And using the name Sema is a bad idea IMHO since this has a totally different meaning in clang.

I'll make another small patch where I rename this.


Repository:
  rL LLVM

https://reviews.llvm.org/D48661