[PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant

Bruno Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 09:54:07 PDT 2018

Previous message: [PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant
Next message: [PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

bricci added a comment.

Just a nit but could you please add new-lines to your commit messages.
Also the 3 bools in FixedPointSemantics are a little bit wasteful.


Repository:
  rL LLVM

https://reviews.llvm.org/D48661

Previous message: [PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant
Next message: [PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list