[PATCH] D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: MicroBenchmarks/ImageProcessing/Blur/main.cpp:175-177
+  if (state.range(0) == 20) {
+    saveImage(outputImage, (const char *)"testFailed.txt", height, width);
+  }
----------------
Meinersbur wrote:
> dberris wrote:
> > Meinersbur wrote:
> > > @dberris Would `::benchmark::ClobberMemory()` be a viable alternative?
> > It may be.
> I suggest to leave it as is for the moment. If we found a canonical approach, we can change this and the other benchmarks afterwards.
> 
> Could you add a comment that this is supposed keep the compiler to optimize the computation away?
@proton Please don't forget to add a comment about that this code is meant to inhibit too-aggressive compiler optimizations.


https://reviews.llvm.org/D49341