[PATCH] D50335: vs integration: fix default path to clang-cl

[Zachary Turner via llvm-commits]

If you go to vs settings you can go to project -> build & run -> output
level and set it to Diagnostic. Then Ctrl+F for LLVMInstallDir and you
should see the value. Try this with @ and with \ and see if they’re
different.

Btw, unfortunately i had a few more changes to the csproj file that I may
have forgotten to upstream before i left. IIRC, they were changing the
author name to LLVMExtensions , deleting the part in the csproj about
Brutal Strong name signer, setting the key file in project settings, and
fixing the path to sn.exe.


Edit: just saw your update. That is such weird installer behavior. What
goes in the LLVM key above that? Maybe the installer behavior changed and
we need to support both?
On Mon, Aug 6, 2018 at 11:22 AM Zachary Turner <zturner at google.com> wrote:

> In that case I think the first version was correct. LLVM at LLVM means “the
> value LLVM under the key LLVM”. LLVM\LLVM means “the default value under
> the key LLVM which itself is under the key LLVM”
> On Mon, Aug 6, 2018 at 11:18 AM Hans Wennborg via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> hans added a comment.
>>
>> In https://reviews.llvm.org/D50335#1189424, @zturner wrote:
>>
>> > I’m OOO this week so I can’t easily check this stuff. Sorry for all the
>> >  questions. The registry key that we create, is it the (Default) value
>> or is
>> >  it a string value named LLVM?
>>
>>
>> If I understand it correctly, it's a string value named LLVM.
>>
>>
>> https://reviews.llvm.org/D50335
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180806/23d4f554/attachment.html>