[PATCH] D50335: vs integration: fix default path to clang-cl

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

In https://reviews.llvm.org/D50335#1189413, @zturner wrote:

> I’m pretty sure I tested this code path, was it wrong?


It didn't work when I tried it.

> Also I don’t think
>  we should be explicitly adding the \ after the $(LLVMInstallDir), if you
>  look through the way every other path in a VS project works, they assume
>  the \ is in the registry path, so if it’s possible I think we should follow
>  the same pattern.

I don't think we should change the path in the registry (for example that would make the vsix not work with old installs), but we can make LLVMInstallDir add a backslash on top of what it gets from the registry.


https://reviews.llvm.org/D50335