[PATCH] D50333: [Tablegen] In TargetSchedule.td: Remove unused argument `pfmCounters` from ProcResourceUnits.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 06:48:13 PDT 2018


andreadb created this revision.
andreadb added reviewers: gchatelet, courbet.

I am pretty sure that this is a no functional change.

PFM counters don't need to be passed in input to the definition of ProcResourceUnits.
class PfmIssueCounter (r329675) is used to map resources to PFM counter(s).

I verified that there is no difference in the code auto-generated by the subtarget emitter.

@gchatelet is this okay to commit?

Thanks in advance
-Andrea


https://reviews.llvm.org/D50333

Files:
  include/llvm/Target/TargetSchedule.td


Index: include/llvm/Target/TargetSchedule.td
===================================================================
--- include/llvm/Target/TargetSchedule.td
+++ include/llvm/Target/TargetSchedule.td
@@ -182,8 +182,7 @@
 //
 // SchedModel ties these units to a processor for any stand-alone defs
 // of this class.
-class ProcResourceUnits<ProcResourceKind kind, int num,
-                        list<string> pfmCounters> {
+class ProcResourceUnits<ProcResourceKind kind, int num> {
   ProcResourceKind Kind = kind;
   int NumUnits = num;
   ProcResourceKind Super = ?;
@@ -198,8 +197,8 @@
 
 // Subtargets typically define processor resource kind and number of
 // units in one place.
-class ProcResource<int num, list<string> pfmCounters = []> : ProcResourceKind,
-  ProcResourceUnits<EponymousProcResourceKind, num, pfmCounters>;
+class ProcResource<int num> : ProcResourceKind,
+  ProcResourceUnits<EponymousProcResourceKind, num>;
 
 class ProcResGroup<list<ProcResource> resources> : ProcResourceKind {
   list<ProcResource> Resources = resources;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50333.159292.patch
Type: text/x-patch
Size: 1052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180806/878b4ad9/attachment.bin>


More information about the llvm-commits mailing list