[PATCH] D50285: [MC] Remove MCRegisterClass::getSize

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 5 11:50:03 PDT 2018


bjope added a comment.

I think that it is about time to at least remove MCRegisterClass::getSize().
Notice that I also suggested to remove getPhysRegSize() (and the PhysRegSize member) in https://reviews.llvm.org/D47199, but it is perhaps more controversial to remove the register size completely from MCRegisterClass?
Afaik there is not in-tree use of getPhysRegSize(). And making it possible to get the size in bytes of a reg class with non-byte-sized registers, without telling that it truncates down to whole bytes, might be a little bit confusing (e.g. getPhysRegSize() for a register class with 1-bit registers will return 0).


https://reviews.llvm.org/D50285





More information about the llvm-commits mailing list