[PATCH] D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 4 22:35:20 PDT 2018


majnemer added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:3635
+  unsigned K = D.countTrailingZeros();
+  APInt D0 = D.ashr(K);
+
----------------
Is this supposed to be ashr even if we are doing UREM? Seems a little unusual but if this is correct, it probably earns a comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D50222





More information about the llvm-commits mailing list