[debuginfo-tests] r338937 - Disable the asan-deque.cpp integration test for AppleLLDB < v1000

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 3 17:02:48 PDT 2018


Author: vedantk
Date: Fri Aug  3 17:02:48 2018
New Revision: 338937

URL: http://llvm.org/viewvc/llvm-project?rev=338937&view=rev
Log:
Disable the asan-deque.cpp integration test for AppleLLDB < v1000

Some of Apple's public CI nodes ship an lldb which has trouble debugging
the asan-deque.cpp test. Specifically, that lldb appears to either parse
location lists in the test program incorrectly or to have a broken
std::deque data formatter.

We don't want to work around this by weakening the integration test, and
we're unable to update the lldb version on the CI node at the moment.

The compromise is to require AppleLLDB >= 1000 when AppleLLDB is being
used to debug this test.

Reviewed (in person) by Adrian Prantl.

Bot failure:
http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA/48074

rdar://42892721

Modified:
    debuginfo-tests/trunk/asan-deque.cpp
    debuginfo-tests/trunk/lit.cfg.py

Modified: debuginfo-tests/trunk/asan-deque.cpp
URL: http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/asan-deque.cpp?rev=338937&r1=338936&r2=338937&view=diff
==============================================================================
--- debuginfo-tests/trunk/asan-deque.cpp (original)
+++ debuginfo-tests/trunk/asan-deque.cpp Fri Aug  3 17:02:48 2018
@@ -3,7 +3,7 @@
 // REQUIRES: not_asan
 //           Zorg configures the ASAN stage2 bots to not build the asan
 //           compiler-rt. Only run this test on non-asanified configurations.
-
+// UNSUPPORTED: apple-lldb-pre-1000
 #include <deque>
 
 struct A {

Modified: debuginfo-tests/trunk/lit.cfg.py
URL: http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/lit.cfg.py?rev=338937&r1=338936&r2=338937&view=diff
==============================================================================
--- debuginfo-tests/trunk/lit.cfg.py (original)
+++ debuginfo-tests/trunk/lit.cfg.py Fri Aug  3 17:02:48 2018
@@ -5,6 +5,7 @@ import platform
 import re
 import subprocess
 import tempfile
+import commands
 
 import lit.formats
 import lit.util
@@ -61,3 +62,11 @@ tools = [
 llvm_config.add_tool_substitutions(tools, tool_dirs)
 
 lit.util.usePlatformSdkOnDarwin(config, lit_config)
+
+if platform.system() == 'Darwin':
+    xcode_lldb_vers = commands.getoutput("xcrun lldb --version")
+    match = re.search('lldb-(\d+)', xcode_lldb_vers)
+    if match:
+        apple_lldb_vers = int(match.group(1))
+        if apple_lldb_vers < 1000:
+            config.available_features.add('apple-lldb-pre-1000')




More information about the llvm-commits mailing list