[PATCH] D50279: [WebAssembly] Don't error when --undefined symbols are not found

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 3 16:47:03 PDT 2018


ruiu added a comment.

Generally looking good.



================
Comment at: wasm/Driver.cpp:487-489
+    // Handle the `--undefined <sym>` options.
+    for (auto *Arg : Args.filtered(OPT_undefined))
+      handleUndefined(Arg->getValue());
----------------
Not sure if this has to be inside a guard for --relocatable. Any reason for that?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50279





More information about the llvm-commits mailing list