[PATCH] D50282: [lit, python] Always add quotes around the python path in lit

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, zturner.
Herald added subscribers: llvm-commits, dexonsmith, steven_wu, aheejin, arichardson, sbc100, emaste.
Herald added a reviewer: espindola.

The issue with the python path is that the path to python on Windows can contain spaces. To make the tests always work, the path to python needs to be surrounded by quotes.

This is a companion change to: https://reviews.llvm.org/D50206


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50282

Files:
  test/ELF/lto/cache.ll
  test/mach-o/dependency_info.yaml
  test/wasm/lto/cache.ll


Index: test/wasm/lto/cache.ll
===================================================================
--- test/wasm/lto/cache.ll
+++ test/wasm/lto/cache.ll
@@ -11,7 +11,7 @@
 ; RUN: ls %t.cache | count 4
 
 ; Create a file of size 64KB.
-; RUN: "%python" -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
+; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
 
 ; This should leave the file in place.
 ; RUN: wasm-ld --thinlto-cache-dir=%t.cache --thinlto-cache-policy cache_size_bytes=128k:prune_interval=0s -o %t.wasm %t2.o %t.o
Index: test/mach-o/dependency_info.yaml
===================================================================
--- test/mach-o/dependency_info.yaml
+++ test/mach-o/dependency_info.yaml
@@ -9,7 +9,7 @@
 # RUN:        -F/Custom/Frameworks \
 # RUN:        -framework Bar \
 # RUN:        -framework Foo
-# RUN: '%python' %p/Inputs/DependencyDump.py %t.info | FileCheck %s
+# RUN: %python %p/Inputs/DependencyDump.py %t.info | FileCheck %s
 
 
 # CHECK: linker-vers: lld
Index: test/ELF/lto/cache.ll
===================================================================
--- test/ELF/lto/cache.ll
+++ test/ELF/lto/cache.ll
@@ -13,7 +13,7 @@
 ; RUN: ls %t.cache | count 4
 
 ; Create a file of size 64KB.
-; RUN: "%python" -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
+; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
 
 ; This should leave the file in place.
 ; RUN: ld.lld --thinlto-cache-dir=%t.cache --thinlto-cache-policy cache_size_bytes=128k:prune_interval=0s -o %t3 %t2.o %t.o


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50282.159125.patch
Type: text/x-patch
Size: 1531 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180803/d9ee07b5/attachment.bin>