[PATCH] D50233: [InstCombine] Transform str(n)cmp to memcmp

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I think you need to add something like "dereferenceable(4)" or "byval" to the parameter. so it's recognized as dereferenceable.

Please get rid of the lifetime.start/end intrinsics in the test.



================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:155
+  if (!isOnlyUsedInZeroEqualityComparison(CI))
+    return false;
+
----------------
xbolva00 wrote:
> efriedma wrote:
> > xbolva00 wrote:
> > > efriedma wrote:
> > > > Not sure why this check is relevant; memcmp should return the same value as strcmp.
> > > \0 in the middle of string?
> > > https://stackoverflow.com/questions/13095513/what-is-the-difference-between-memcmp-strcmp-and-strncmp-in-c
> > > 
> > > I think the check is probably right here..
> > I'm not sure what you mean... as far as I can tell, strcmp and memcmp should return the same result even if the non-constant string has an embedded null.  Can you give an example?  (I'm interpreting "same" here loosely to mean the same zero-ness and same sign bit.)
> Yeah, sign bit is same, but values are not. So need to check only if it is only used in condition
The C standard doesn't specify a specific return value; we don't have to return exactly the same value libc strcmp would return anyway, I think?  Haven't really thought through the implications of that.  It's okay to leave it for now.


https://reviews.llvm.org/D50233