[PATCH] D50220: [DebugInfo] Refactor DbgInfoIntrinsic class hierarchy.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Two totally optional style nits.  The new class distinction seems like an improvement.



================
Comment at: include/llvm/IR/InstVisitor.h:215
+  RetTy visitDbgDeclareInst(DbgDeclareInst &I){ DELEGATE(DbgVariableIntrinsic);}
+  RetTy visitDbgValueInst(DbgValueInst &I)    { DELEGATE(DbgVariableIntrinsic);}
+  RetTy visitDbgVariableIntrinsic(DbgVariableIntrinsic &I)
----------------
Nit: I'd prefer the braces here to line up with the braces for the following Dbg intrinsics.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5179
   case Intrinsic::dbg_declare: {
-    const DbgInfoIntrinsic &DI = cast<DbgInfoIntrinsic>(I);
+    const DbgVariableIntrinsic &DI = cast<DbgVariableIntrinsic>(I);
     DILocalVariable *Variable = DI.getVariable();
----------------
This could be `const auto &DI`.


Repository:
  rL LLVM

https://reviews.llvm.org/D50220