[PATCH] D50258: [llvm-pdbutil] Support PDBs without a DBI stream

[Alexandre Ganea via Phabricator via llvm-commits]

aganea created this revision.
aganea added reviewers: zturner, rnk.
Herald added a subscriber: llvm-commits.

This change ensures `llvm-pdb` doesn't fail on start, when the DBI stream isn't present in the PDB.

This occurs when compiling a simple .cpp with /Zi (see attached test)

Also, normalized the formatting of the errors printed by `llvm-pdbutil` in that case.

Tested all commands with the provided PDB, only `llvm-pdbutil dump ...` and `llvm-pdbutil pdb2yaml ...` seemed to be previously affected by the issue.


Repository:
  rL LLVM

https://reviews.llvm.org/D50258

Files:
  lib/DebugInfo/PDB/Native/PDBFile.cpp
  test/tools/llvm-pdbdump/Inputs/TypeServerTest.cpp
  test/tools/llvm-pdbdump/Inputs/TypeServerTest.obj
  test/tools/llvm-pdbdump/Inputs/TypeServerTest.pdb
  test/tools/llvm-pdbdump/type-server-no-dbi.test
  tools/llvm-pdbutil/DumpOutputStyle.cpp
  tools/llvm-pdbutil/DumpOutputStyle.h
  tools/llvm-pdbutil/YAMLOutputStyle.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50258.159016.patch
Type: text/x-patch
Size: 14458 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180803/c85476e4/attachment.bin>