[PATCH] D50213: DebugInfo: Add metadata support for disabling DWARF pub sections

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In https://reviews.llvm.org/D50213#1187506, @JDevlieghere wrote:

> Regarding the naming: I like `PubnameKind` because of the aforementioned consistency (we also have `AccelTableKind`. Can't we use an `enum class` to prevent collisions?


I submitted this before looking at the diff, I guess the reason is that you want to convert to unsigned.



================
Comment at: include/llvm/IR/DebugInfoMetadata.h:1172
+    GNU = 1,
+    Omitted = 2,
+    LastPubnamesKind = Omitted
----------------
Maybe `NoPubnames` like `NoDebug`?


Repository:
  rL LLVM

https://reviews.llvm.org/D50213