[PATCH] D48100: Append new attributes to the end of an AttributeList.

[Aaron Ballman via llvm-commits]

On Fri, Aug 3, 2018 at 8:53 AM, Erich Keane via Phabricator
<reviews at reviews.llvm.org> wrote:
> erichkeane added a comment.
>
> In https://reviews.llvm.org/D48100#1186654, @Meinersbur wrote:
>
>> I have two approaches to tackle the wrong marker order: https://reviews.llvm.org/D50215 and https://reviews.llvm.org/D50216. IMHO both are too invasive to be justified for the small issue.
>
>
> I think you're right here.  I despise https://reviews.llvm.org/D50215, and only mostly hate https://reviews.llvm.org/D50216.  I think I'd prefer leaving this as a "FIXME" somewhere.

Oye, I'm in agreement that this should be fixed but that neither of
these approaches leaves me feeling warm and fuzzy.

As a possible idea (that may or may not work): the Attr object itself
has a SourceRange on it; perhaps a solution is to keep the attributes
in sorted order within DeclBase::addAttr() based on the SourceRanges
passed in?

~Aaron

>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D48100
>
>
>