[PATCH] D50237: [DebugInfo/Verifier] Don't emit error for missing module in index

[Jonas Devlieghere via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL338878: [DebugInfo/Verifier] Don't emit error for missing module in index (authored by JDevlieghere, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D50237?vs=158969&id=158980#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D50237

Files:
  llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/trunk/test/DebugInfo/X86/DIModule.ll


Index: llvm/trunk/test/DebugInfo/X86/DIModule.ll
===================================================================
--- llvm/trunk/test/DebugInfo/X86/DIModule.ll
+++ llvm/trunk/test/DebugInfo/X86/DIModule.ll
@@ -1,6 +1,7 @@
 ; ModuleID = '/Volumes/Data/apple-internal/llvm/tools/clang/test/Modules/debug-info-moduleimport.m'
-; RUN: llc %s -o %t -filetype=obj
+; RUN: llc %s -accel-tables=Dwarf -o %t -filetype=obj
 ; RUN: llvm-dwarfdump -debug-info %t | FileCheck %s
+; RUN: llvm-dwarfdump -verify %t
 ; CHECK: DW_TAG_module
 ; CHECK-NEXT: DW_AT_name {{.*}}"DebugModule"
 ; CHECK-NEXT: DW_AT_LLVM_config_macros {{.*}}"-DMODULES=0"
Index: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
===================================================================
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
@@ -1211,8 +1211,9 @@
   // make sure we catch any missing items, we instead blacklist all TAGs that we
   // know shouldn't be indexed.
   switch (Die.getTag()) {
-  // Compile unit has a name but it shouldn't be indexed.
+  // Compile units and modules have names but shouldn't be indexed.
   case DW_TAG_compile_unit:
+  case DW_TAG_module:
     return 0;
 
   // Function and template parameters are not globally visible, so we shouldn't


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50237.158980.patch
Type: text/x-patch
Size: 1305 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180803/265ac60a/attachment.bin>