[llvm] r338878 - [DebugInfo/Verifier] Don't emit error for missing module in index

[Jonas Devlieghere via llvm-commits]

Author: jdevlieghere
Date: Fri Aug  3 05:01:43 2018
New Revision: 338878

URL: http://llvm.org/viewvc/llvm-project?rev=338878&view=rev
Log:
[DebugInfo/Verifier] Don't emit error for missing module in index

We don't expect module names to be present in the index. This patch adds
DW_TAG_module to the blacklist.

Differential revision: https://reviews.llvm.org/D50237

Modified:
    llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
    llvm/trunk/test/DebugInfo/X86/DIModule.ll

Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp?rev=338878&r1=338877&r2=338878&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp (original)
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp Fri Aug  3 05:01:43 2018
@@ -1211,8 +1211,9 @@ unsigned DWARFVerifier::verifyNameIndexC
   // make sure we catch any missing items, we instead blacklist all TAGs that we
   // know shouldn't be indexed.
   switch (Die.getTag()) {
-  // Compile unit has a name but it shouldn't be indexed.
+  // Compile units and modules have names but shouldn't be indexed.
   case DW_TAG_compile_unit:
+  case DW_TAG_module:
     return 0;
 
   // Function and template parameters are not globally visible, so we shouldn't

Modified: llvm/trunk/test/DebugInfo/X86/DIModule.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/DIModule.ll?rev=338878&r1=338877&r2=338878&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/X86/DIModule.ll (original)
+++ llvm/trunk/test/DebugInfo/X86/DIModule.ll Fri Aug  3 05:01:43 2018
@@ -1,6 +1,7 @@
 ; ModuleID = '/Volumes/Data/apple-internal/llvm/tools/clang/test/Modules/debug-info-moduleimport.m'
-; RUN: llc %s -o %t -filetype=obj
+; RUN: llc %s -accel-tables=Dwarf -o %t -filetype=obj
 ; RUN: llvm-dwarfdump -debug-info %t | FileCheck %s
+; RUN: llvm-dwarfdump -verify %t
 ; CHECK: DW_TAG_module
 ; CHECK-NEXT: DW_AT_name {{.*}}"DebugModule"
 ; CHECK-NEXT: DW_AT_LLVM_config_macros {{.*}}"-DMODULES=0"