[PATCH] D50235: [yaml2obj] - Add a support for changing EntSize.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:464
     OS.write(0);
-  if (Section.Type == llvm::ELF::SHT_RELR)
+  if (Section.EntSize != 0)
+    SHeader.sh_entsize = Section.EntSize;
----------------
grimar wrote:
> jhenderson wrote:
> > What if a user explicitly requests EntSize 0? I would expect that to override the defaults as much as 1 does.
> Interesting case, but should we support it right how?
I don't think it's any different a case to EntSize 1, 2 etc in a SHT_RELR/DYNAMIC etc section.

We could avoid it by using the explicit value only when the section type doesn't imply it, but I'd rather keep the explicit version.


https://reviews.llvm.org/D50235