[PATCH] D50235: [yaml2obj] - Add a support for changing EntSize.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 3 04:34:55 PDT 2018


jhenderson added inline comments.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:464
     OS.write(0);
-  if (Section.Type == llvm::ELF::SHT_RELR)
+  if (Section.EntSize != 0)
+    SHeader.sh_entsize = Section.EntSize;
----------------
What if a user explicitly requests EntSize 0? I would expect that to override the defaults as much as 1 does.


https://reviews.llvm.org/D50235





More information about the llvm-commits mailing list