[llvm] r338843 - [NFC] Move some methods into static functions
Max Kazantsev via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 3 03:16:40 PDT 2018
Author: mkazantsev
Date: Fri Aug 3 03:16:40 2018
New Revision: 338843
URL: http://llvm.org/viewvc/llvm-project?rev=338843&view=rev
Log:
[NFC] Move some methods into static functions
Modified:
llvm/trunk/lib/Transforms/Scalar/GuardWidening.cpp
Modified: llvm/trunk/lib/Transforms/Scalar/GuardWidening.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/GuardWidening.cpp?rev=338843&r1=338842&r2=338843&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/GuardWidening.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/GuardWidening.cpp Fri Aug 3 03:16:40 2018
@@ -66,6 +66,33 @@ STATISTIC(GuardsEliminated, "Number of e
namespace {
+static Value *getGuardCondition(Instruction *GuardInst) {
+ IntrinsicInst *GI = cast<IntrinsicInst>(GuardInst);
+ assert(GI->getIntrinsicID() == Intrinsic::experimental_guard &&
+ "Bad guard intrinsic?");
+ return GI->getArgOperand(0);
+}
+
+// Set the condition for \p GuardInst to \p NewCond.
+static void setGuardCondition(Instruction *GuardInst, Value *NewCond) {
+ IntrinsicInst *GI = cast<IntrinsicInst>(GuardInst);
+ assert(GI->getIntrinsicID() == Intrinsic::experimental_guard &&
+ "Bad guard intrinsic?");
+ GI->setArgOperand(0, NewCond);
+}
+
+// Whether or not the particular instruction \p I is a guard.
+static bool isGuard(const Instruction *I) {
+ using namespace llvm::PatternMatch;
+ return match(I, m_Intrinsic<Intrinsic::experimental_guard>());
+}
+
+// Eliminates the guard instruction properly.
+static void eliminateGuard(Instruction *GuardInst) {
+ GuardInst->eraseFromParent();
+ ++GuardsEliminated;
+}
+
class GuardWideningImpl {
DominatorTree &DT;
PostDominatorTree *PDT;
@@ -93,18 +120,6 @@ class GuardWideningImpl {
const DenseMap<BasicBlock *, SmallVector<Instruction *, 8>> &
GuardsPerBlock);
- // Get the condition from \p GuardInst.
- Value *getGuardCondition(Instruction *GuardInst);
-
- // Set the condition for \p GuardInst.
- void setGuardCondition(Instruction *GuardInst, Value *NewCond);
-
- // Whether or not the particular instruction is a guard.
- bool isGuard(const Instruction *I);
-
- // Eliminates the guard instruction properly.
- void eliminateGuard(Instruction *GuardInst);
-
/// Used to keep track of which widening potential is more effective.
enum WideningScore {
/// Don't widen.
@@ -343,31 +358,6 @@ bool GuardWideningImpl::eliminateGuardVi
return true;
}
-Value *GuardWideningImpl::getGuardCondition(Instruction *GuardInst) {
- IntrinsicInst *GI = cast<IntrinsicInst>(GuardInst);
- assert(GI->getIntrinsicID() == Intrinsic::experimental_guard &&
- "Bad guard intrinsic?");
- return GI->getArgOperand(0);
-}
-
-void GuardWideningImpl::setGuardCondition(Instruction *GuardInst,
- Value *NewCond) {
- IntrinsicInst *GI = cast<IntrinsicInst>(GuardInst);
- assert(GI->getIntrinsicID() == Intrinsic::experimental_guard &&
- "Bad guard intrinsic?");
- GI->setArgOperand(0, NewCond);
-}
-
-bool GuardWideningImpl::isGuard(const Instruction* I) {
- using namespace llvm::PatternMatch;
- return match(I, m_Intrinsic<Intrinsic::experimental_guard>());
-}
-
-void GuardWideningImpl::eliminateGuard(Instruction *GuardInst) {
- GuardInst->eraseFromParent();
- ++GuardsEliminated;
-}
-
GuardWideningImpl::WideningScore GuardWideningImpl::computeWideningScore(
Instruction *DominatedGuard, Loop *DominatedGuardLoop,
Instruction *DominatingGuard, Loop *DominatingGuardLoop) {
More information about the llvm-commits
mailing list