[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Hi @plotfi,

Would you mind when you mark things as done, to upload the latest diff, as it makes it a little confusing for me seeing something marked as "done" when it doesn't appear to have been yet (might be best to then hold off marking off things as done until you are ready to upload).



================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:727-728
 
-static void ExecuteElfObjcopyOnArchive(const CopyConfig &Config, const Archive &Ar) {
+static void ExecuteElfObjcopyOnArchive(const CopyConfig &Config,
+                                       const Archive &Ar) {
   std::vector<NewArchiveMember> NewArchiveMembers;
----------------
plotfi wrote:
> jhenderson wrote:
> > Do this in a separate NFC commit.
> I will do an NFC Commit without starting another review the, FYI. 
Fine by me.


Repository:
  rL LLVM

https://reviews.llvm.org/D49678