[PATCH] D50191: [ARM] FP16: support VFMA

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 3 01:47:51 PDT 2018


SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMInstrNEON.td:4742
+          (VFMAhq QPR:$src1, QPR:$Vn, QPR:$Vm)>,
+          Requires<[HasFullFP16]>;
 def : Pat<(v2f32 (fma DPR:$Vn, DPR:$Vm, DPR:$src1)),
----------------
efriedma wrote:
> I guess this should also check HasNEON, for completeness? Unlikely to make a difference in practice.
Yes, thanks! I will add this.


https://reviews.llvm.org/D50191





More information about the llvm-commits mailing list