[PATCH] D49661: [RISCV] Add "lla" pseudo-instruction to assembler

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 3 00:55:49 PDT 2018


rogfer01 updated this revision to Diff 158938.
rogfer01 marked 2 inline comments as done.
rogfer01 added a comment.

Thanks @asb for the review!

ChangeLog:

- Rename `ForceImmediateOperand` → `shouldForceImediateOperand`.
- Add comment to `shouldForceImediateOperand`
- Fix `mayLoad` it can be `mayLoad = 0` because this is like `li`, no memory is actually read.
- Update comments to avoid suggesting that `lla` loads memory.


https://reviews.llvm.org/D49661

Files:
  lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  lib/Target/RISCV/RISCVInstrInfo.td
  test/MC/RISCV/lla-invalid.s
  test/MC/RISCV/rvi-pseudos.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49661.158938.patch
Type: text/x-patch
Size: 6182 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180803/fa09348f/attachment.bin>


More information about the llvm-commits mailing list