[PATCH] D50166: [ARM64] [Windows] MCLayer support for exception handling

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> Perhaps I can create a MIR test case with the SEH opcodes, and use llvm-objdump to check the .xdata section?

This seems reasonable.



================
Comment at: lib/MC/MCWin64EH.cpp:537
+           info->EpilogMap.begin();
+       it != info->EpilogMap.end(); ++it) {
+    std::vector<WinEH::Instruction> EpilogInstr = it->second;
----------------
Non-deterministic output, I think, since the keys of EpilogMap are pointers.


================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFStreamer.cpp:66
                                        std::move(Emitter), std::move(OW));
+  S->getAssembler().setRelaxAll(RelaxAll);
   S->getAssembler().setIncrementalLinkerCompatible(IncrementalLinkerCompatible);
----------------
Please commit separately?  (Although, I'm not sure it matters: IIRC AArch64 assemblers can't relax anything anyway.)


Repository:
  rL LLVM

https://reviews.llvm.org/D50166