[PATCH] D50052: [LLD] Improve handling of AT> linker script commands

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Could you give me a few days to review code since we are working in different time zones?



================
Comment at: lld/trunk/ELF/Writer.cpp:1823
     uint64_t NewFlags = computeFlags(Sec->getPhdrFlags());
-    if ((Sec->LMAExpr && Load->LastSec != Out::ProgramHeaders) ||
+    if (((Sec->LMAExpr ||
+          (Sec->LMARegion && (Sec->LMARegion != Load->FirstSec->LMARegion))) &&
----------------
It feels to me that the condition is now too complicated. The code for the linker script is basically too complicated, and I don't like to add too much complexity.


Repository:
  rL LLVM

https://reviews.llvm.org/D50052