[PATCH] D50184: lld-link: Fix subsystem inference for non-console apps on 32-bit, and fix entry point inference on 32-bit with /nodefaultlib

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: COFF/Driver.cpp:418
 
+bool LinkerDriver::findUnderscoreMangle(StringRef Sym) {
+  StringRef Entry = Symtab->findMangle(mangle(Sym));
----------------
ruiu wrote:
> I believe this can be a non-member static function.
Yes, if I make ::mangle() a local static too (which in return requires moving it up a bit). Want me to do this in this patch? I'm attaching the new diff so that you can see how it looks.


https://reviews.llvm.org/D50184