[PATCH] D50174: [LLD][ELF] - Remove dead code from ArchiveFile.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 2 15:31:40 PDT 2018


ruiu added a comment.

I think this change is a bit dangerous to land because this patch removes the safeguard to not pull out the same object file more than once from an archive file. If our symbol resolution logic is as simple as you described, and if consistency between archive file index and actual object files in it is maintained for all input files, this change should be fine. But I think taking that risk is unnecessary. (I vaguely remember that there was a some problem if we don't have this code, but I can't remember it now.)


https://reviews.llvm.org/D50174





More information about the llvm-commits mailing list