[PATCH] D49901: [analyzer] Extend NoStoreFuncVisitor to recursively follow fields

Artem Dergachev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 2 15:13:49 PDT 2018


NoQ added inline comments.


================
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:354-356
+      Optional<unsigned> AdjustedIdx = Call->getAdjustedParameterIndex(I);
+      if (!AdjustedIdx)
+        continue;
----------------
Uhm! I realized that i was wrong about this one. You don't need the adjustment when iterating through CallEvent arguments; you only need it when iterating through CallExpr arguments, which are also conveniently shifted against each other.


Repository:
  rL LLVM

https://reviews.llvm.org/D49901





More information about the llvm-commits mailing list