[PATCH] D49942: [ASAN] Port asan to FreeBSD/mips64.

[John Baldwin via Phabricator via llvm-commits]

bsdjhb added inline comments.


================
Comment at: lib/asan/asan_mapping.h:220
 #    define SHADOW_OFFSET kSystemZ_ShadowOffset64
-#  elif SANITIZER_FREEBSD
+#  elif SANITIZER_FREEBSD && !defined(__mips64)
 #    define SHADOW_OFFSET kFreeBSD_ShadowOffset64
----------------
jrtc27 wrote:
> Is there a reason why you don't just hoist the `__mips64` case up to line 215 to come before this, like is done for 32-bit MIPS on line 188?
Actually, I meant to ask that as a comment when I posted this in terms of what do folks think is the better approach.  Thanks for the reminder.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49942