[llvm] r338751 - CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING

[Tom Stellard via llvm-commits]

On 08/02/2018 11:16 AM, Tom Stellard via llvm-commits wrote:
> Author: tstellar
> Date: Thu Aug  2 11:16:10 2018
> New Revision: 338751
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=338751&view=rev
> Log:
> CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING
> 
> Summary:
> This option is no longer needed since r300496 added symbol
> versioning by default
> 
> Reviewers: sylvestre.ledru, beanz, mgorny
> 
> Reviewed By: mgorny
> 
> Subscribers: llvm-commits
> 
> Differential Revision: https://reviews.llvm.org/D49835
> 

Hi Hans,

Can we merge this patch to the 7.0 branch?

-Tom

> Modified:
>     llvm/trunk/CMakeLists.txt
>     llvm/trunk/tools/llvm-shlib/CMakeLists.txt
> 
> Modified: llvm/trunk/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=338751&r1=338750&r2=338751&view=diff
> ==============================================================================
> --- llvm/trunk/CMakeLists.txt (original)
> +++ llvm/trunk/CMakeLists.txt Thu Aug  2 11:16:10 2018
> @@ -557,8 +557,6 @@ if(LLVM_LINK_LLVM_DYLIB OR LLVM_BUILD_LL
>  endif()
>  option(LLVM_BUILD_LLVM_DYLIB "Build libllvm dynamic library" ${LLVM_BUILD_LLVM_DYLIB_default})
>  
> -option(LLVM_DYLIB_SYMBOL_VERSIONING OFF)
> -
>  option(LLVM_OPTIMIZED_TABLEGEN "Force TableGen to be built with optimization" OFF)
>  if(CMAKE_CROSSCOMPILING OR (LLVM_OPTIMIZED_TABLEGEN AND (LLVM_ENABLE_ASSERTIONS OR CMAKE_CONFIGURATION_TYPES)))
>    set(LLVM_USE_HOST_TOOLS ON)
> 
> Modified: llvm/trunk/tools/llvm-shlib/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-shlib/CMakeLists.txt?rev=338751&r1=338750&r2=338751&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-shlib/CMakeLists.txt (original)
> +++ llvm/trunk/tools/llvm-shlib/CMakeLists.txt Thu Aug  2 11:16:10 2018
> @@ -59,10 +59,6 @@ endif()
>  
>  target_link_libraries(LLVM PRIVATE ${LIB_NAMES})
>  
> -if (LLVM_DYLIB_SYMBOL_VERSIONING)
> -  set_property(TARGET LLVM APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--default-symver")
> -endif()
> -
>  if (APPLE)
>    set_property(TARGET LLVM APPEND_STRING PROPERTY
>                LINK_FLAGS
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>