[PATCH] D49982: [TailCallElim] Preserve DT and PDT

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 2 10:45:28 PDT 2018


brzycki added inline comments.


================
Comment at: lib/Transforms/Scalar/TailRecursionElimination.cpp:596
     }
+    DTU.recalculate(*NewEntry->getParent());
   }
----------------
kuhar wrote:
> Can you add a comment explaining why we have to recalculate here?
+1. recalculate is very expensive and it should become practice for anyone using it to have to describe why a caller has to fall back on this can't rely on the normal API.


https://reviews.llvm.org/D49982





More information about the llvm-commits mailing list