[PATCH] D49807: [Dominators] Make DTU be able to delete a BB before recalculation under Eager UpdateStrategy

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added inline comments.


================
Comment at: include/llvm/IR/DomTreeUpdater.h:150
+  /// When both DT and PDT are nullptrs, DelBB will be queued until flush() is
+  /// called.
+  void deleteBB(BasicBlock *DelBB, bool DisableNodeErasing = false);
----------------
It would be a good idea to add the reason why you need this flag, not just what it does. The comments at the top of this ticket would be a good start to add here.

The reason it's necessary is a subtle one and may not be obvious to users of your API.


Repository:
  rL LLVM

https://reviews.llvm.org/D49807