[PATCH] D48967: [Dominators] Convert existing passes and utils to use the DomTreeUpdater class

Chijun Sima via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 2 10:32:08 PDT 2018


NutshellySima added a comment.

In https://reviews.llvm.org/D48967#1185987, @brzycki wrote:

> LGTM. I like how this revision of the patch is minimally invasive and most of the hard work is hidden in DTU. I strongly recommend running `ninja check`, `ninja check-all`, and a standard test-suite run on tip before committing.
>
> Thank you for your hard work and patience on refactoring this interface @NutshellySima .


Thanks for reviewing. I'll sure to test before committing.


https://reviews.llvm.org/D48967





More information about the llvm-commits mailing list