[PATCH] D48283: [SCEV] Properly solve quadratic equations

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 2 09:25:25 PDT 2018


sanjoy accepted this revision.
sanjoy added a comment.

lgtm



================
Comment at: include/llvm/ADT/APInt.h:2193
+/// an *unsigned* overflow (if the values are treated as unsigned).
+/// To find a solution for a signed overflow, use a range with of BW-1.
+///
----------------
Do you meant to say that "if the coeffs are positive then use a range of BW-1 to find a solution for signed overflow"?


Repository:
  rL LLVM

https://reviews.llvm.org/D48283





More information about the llvm-commits mailing list